Maxime U Garcia

Results 406 comments of Maxime U Garcia

I've been updating stub for modules in rnaseq cf https://github.com/nf-core/rnaseq/pull/1335 And I noticed some issues in some of the modules I worked on: - stub do not exist (which is...

My preference goes to version2, which I find more explicit, easier to read, but I do love the version3 that removes completely the version generation from the script itself.

Agreeing with @pinin4fjords there, version3 looks beautiful as long as all works well, when it starts to bug, it's a mess to debug.

I'm concerned that this test is failing on docker only

Can we instead update the modules upstream and add something like? ``` def output = meta.single_end || meta.one_strand ? "-o ${prefix}.fastq.gz" : "-o ${prefix}_R1.fastq.gz ${prefix}_R2.fastq.gz" ```

> > Can we instead update the modules upstream and add something like? > > ``` > > def output = meta.single_end || meta.one_strand ? "-o ${prefix}.fastq.gz" : "-o ${prefix}_R1.fastq.gz...

Because technically using `meta.single_end` would make sense, but we don't have single_end data, just the one strand with this file, so something like `meta.one_strand` would be better in our case....

> > Because technically using `meta.single_end` would make sense, but we don't have single_end data, just the one strand with this file, so something like `meta.one_strand` would be better in...

Let's kill this one and replace with a MULTIQC module from nf-core