tools icon indicating copy to clipboard operation
tools copied to clipboard

Add nf-prov

Open maxulysse opened this issue 2 years ago • 5 comments

PR checklist

  • [ ] This comment contains a description of changes (with reason)
  • [ ] CHANGELOG.md is updated
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
  • [ ] Documentation in docs is updated

maxulysse avatar Sep 29 '23 07:09 maxulysse

Good, though I wonder if it's worth trialling in a pipeline or two for a while before merging into the template? Just because the plugin is very new and not super well tested yet.

Could arguably do this alongside merging to the template I guess, so maybe no need to hold this up.

ewels avatar Sep 29 '23 07:09 ewels

Good, though I wonder if it's worth trialling in a pipeline or two for a while before merging into the template? Just because the plugin is very new and not super well tested yet.

Could arguably do this alongside merging to the template I guess, so maybe no need to hold this up.

I can test in Sarek

maxulysse avatar Sep 29 '23 07:09 maxulysse

Good, though I wonder if it's worth trialling in a pipeline or two for a while before merging into the template? Just because the plugin is very new and not super well tested yet. Could arguably do this alongside merging to the template I guess, so maybe no need to hold this up.

I can test in Sarek

https://github.com/nf-core/sarek/pull/1259

maxulysse avatar Sep 29 '23 07:09 maxulysse

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.61%. Comparing base (f7207a5) to head (f803a60).

Additional details and impacted files

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Sep 29 '23 07:09 codecov[bot]

Works in taxprofiler :+1:

jfy133 avatar Sep 29 '23 08:09 jfy133