Max Katz

Results 106 comments of Max Katz

Add `cuda::std::variant`, `cuda::std::visit`, and `cuda::std::monostate`

@brycelelbach I second the request for std::variant and friends in device code, or equivalent functionality with a similar API. This comes up commonly in some of the DOE multiphysics simulation...

state_nghost gives different answers

There is a difference here even if all (non-hydro) source terms are turned off. In that case, the only possible explanation for the difference is that the ghost zones in...

state_nghost gives different answers

I do not think there is any problem here, actually. Even when the EOS is gamma law and all physics (including hydro) is turned off, there's a diff at roundoff...

convert from Elixir to Async Arena

Related: #1578, #1587

Replace monopole gravity with Poisson gravity?

@asalmgren a penny for your thoughts

not all FABs in hydro need 4 ghost cells

It would be nice if we can devise a flattening algorithm that only requires one cell to the left and right for pressure.

make finest level dx() known at probinit time

This routine would be called from the Castro constructor after `buildMetrics()` has been called, and should only be done by the level 0 constructor.

implement the CMA method

Do we still want to do this?

Is FillPatch needed in diffusion?

We'll also need to figure out what to do for the source term evaluation in the reflux if `update_sources_after_reflux = 1` since we won't have Sborder anymore.

Is FillPatch needed in diffusion?

Another issue to think about is that using Sborder instead of S_old will change answers for problems with reactions. Technically, I think we should have been using Sborder all along.