Max Katz

Results 106 comments of Max Katz

> it surely depends on resolution though, right? It does. At resolutions of 100 km, 50 km, and 25 km, the peak temperatures during the run are 6.2e8 K, 3.4e8...

Note this also applies to rotation.

I would like to actually do this because it is my goal to implement fully conservative gravity and rotation options that are applied directly to the fluxes (for both momentum...

For constant gravity, the source term is very similar in both cases, except that the energy source term evaluates the time-centered (rho * v * g) at zone edges rather...

grav_source_type == 4 only matters for the corrector source, this shouldn't change anything for MOL/SDC.

Yes. That is one of the things I will pursue in a later PR.

Yes, the conservative formulation works for axisymmetric/spherical geometries.

@zingale can you provide a specific reproducer for the flame_wave issue?

I was able to reproduce this after 3234 steps with ``` jsrun -n 8 -a 1 -g 1 ./Castro2d.pgi.MPI.CUDA.ex inputs.noboost.500Hz castro.grav_source_type=4 amr.max_grid_size=1152 ``` The code is crashing because of CFL...

Assigning this to myself as part of the radiation cleanup I'm doing.