Max Katz
Max Katz
The above change makes things slightly worse for test_react with subch_full. Before: ``` $ ./main3d.gnu.ex inputs_aprox21 integrator.use_jacobian_caching=0 integrator.jacobian=1 AMReX (22.03-26-ge213d767baab) initialized reading extern runtime parameters ... reading in network electron-capture...
I don't think we can get std::string to work. However here is one way to do it. Right now we are returning a simple success code of 0 or 1....
Let's make sure to change the name of the field from `success` if we do that. I don't want anyone to have subtle errors because a user updated Microphysics but...
Some aspects of this were addressed in #624 which automatically computes the derivatives with respect to Y in the Jacobian terms. However (at least for the aprox rates) we are...
Yes, evenly distributed is the easiest, I am fine with that.
We can use this to test #710 to (numerically) verify that the new implementation mathematically matches the old.
It's really not good we do the ydot = 0 thing. Instead, now that we're not integrating T, we could just floor or ceiling the temperature to mintemp or maxtemp...
Note: this does not yet actually remove EXTRA_THERMO, it just makes some parts of Microphysics agnostic as to whether the eos_t object has dpdA, etc., in the type. When this...
An alternative is to employ a mask that determines which species of a network we are currently integrating.
If we wanted to use the mask and also make it automated, perhaps we could specify some tolerance levels below which a given isotope is automatically not integrated (e.g. X...