Max Katz

Results 106 comments of Max Katz

use std::expected to handle burn failures?

What is an example of something this enables that we can't do right now (with the burn status stored in the burn_t)?

switch sum_utils to use AMReX volwgtsum

I'd have to remember more closely why I did #2158 in order to get to #2164, but just worth noting for later that AMReX now does this a little different...

enable GPU-aware MPI when performance conditions are met

This issue is more complex than whether or not IPC is available, since a large number of cases relevant to AMReX users are going to be on large (100s to...

Compute some Jacobian terms at compilation time

Closing, this referred to an older version of the code

For aprox13, rate tabulation should be the default

Closing as resolved -- whether or not to use rate tabulation for the aprox networks is now a Microphysics-wide parameter.

use C++ autodiff to do Jacobians

For the aprox networks, we could straightforwardly implement this in a way where nothing changes about that, because we're already only filling in Jacobian terms if the species we're taking...

implement a simple C++ backward Euler integrator

Results of this integrator on the test in #632: ``` $ ./main3d.gnu.ex inputs_aprox13_mott unit_test.tmax = 1.e2 AMReX (22.11-14-ge0afc82f63ce) initialized starting the single zone burn... Maximum Time (s): 100 State Density...

for retry after burning fail, we can use the time from burn_t

This wouldn't be that hard to try. I don't have a good prediction about whether it would help; sometimes cutting the step by 2 will be just fine for new-time...

for retry after burning fail, we can use the time from burn_t

This can be supported by adding a `suggested_dt` member to `advance_status`, if `react_state` returns that as desired then it should be straightforward to experiment with this. And we might have...

Package usage for specific MHD applications

Sorry, Castro would probably not be helpful for that use case, we have not done any development work for liquids, only gases.