Max Katz
Max Katz
**Parameter changes I think are unambiguously good:** - castro.use_retry = 1 Retries are a great way to avoid CFL violations that result in the simulation dying. Most newer users do...
Yes, that's true.
For castro.source_term_predictor we should probably wait until we fix #154
I'd prefer just to remove it entirely. I don't think it's a good option.
I'm OK with disabling it in this case as it is clearly wrong, but please leave this issue open after we merge #545. I'd like to investigate whether it's possible...
My initial thought was that since the final time node is always n+1 (right?) then we could just re-evaluate the old sources and add the appropriate weighting.
A note on the history here: when this functionality was first introduced we had several ways of estimating de/dt: https://github.com/AMReX-Astro/Castro/blob/e278d91f1af5c067d2c98fbfa902d5f3d1c6f9ea/Source/driver/timestep.F90#L216-L248 The versions other than "instantaneously call the RHS" were ditched...
In order to test out different ideas, I think we would need to concretely identify a case where a zone burns to NSE in a single timestep but where it...
I've split off the hydro parts of the header into hydro/Castro_hydro.H and hydro/Castro_hydro_F.H. Note that I didn't create sub-classes for them, they're just treated as text files that get #include'd...
The heating primarily happens near the (trailing) edge of the star. So it may be that a disproportionate amount of kinetic energy is being transferred to the lower density zones,...