Max Katz
Max Katz
It would also be good to be more consistent about this throughout the code because we already treat the boundary values on `phi` as edge values.
This would address #392. Also, I suppose it doesn't need to be a counter, it can just be a bool (either consistent or inconsistent).
This is because the radiation energy is negative on level 2. (So the NaN is coming from when we do something like `sqrt(q(QRAD)` in ctoprim.) The negative radiation energy is...
If I understand this correctly, it's basically doing what the code was doing before we merged #1379, except it's being handled closer to where the negative mass fraction is being...
Yes, I would be OK with this if we also did the proposed VODE fix.
#734 was our attempt at this in Fortran
I think this is still technically an issue. Even if there is not a viscous mechanism to actually generate a no-slip wall, we do have a boundary condition and one...
Here is one way we could do it for Strang-split burning in react_state: ``` if (verbose > 1) { Real avg_work_done = w.sum(0) / grids.numPts(); amrex::Print()
Yes, a similar thing should work for simplified SDC.
We also want the git submodules to (recursively) update after `git checkout` and `git merge`.