Results 262 comments of l0rinc

I have measured these commits separately against a baseline (undoing each commit, to measure them independently). * 1d281daf86 `Merge bitcoin/bitcoin#32095: doc: clarify that testnet min-difficulty` is the **baseline** * 1112433318...

ACK df27ee9f024f69a8bdac8b0ee3bd7882f6a54294

Most of my observations should rather be addressed in a [separate PR](https://github.com/bitcoin/bitcoin/pull/30999) (can be merged before or after, I don't mind rebasing, would appreciate a review there). I'm fine with...

ACK 4f33e9a85c3a8f546deddc2f78cf74bceff30315

I'm not in love with the `DEBUG` separation, but I'm fine with it if others are. ACK 49f73071a8ec4131595090a619d6198a5f8b7c3c `git range-diff 4f33e9a85c3a8f546deddc2f78cf74bceff30315~4..4f33e9a85c3a8f546deddc2f78cf74bceff30315 aba9ce0eb6e67945f2209a17676f356fe9748 7e6..928538e3782ccbb22f54f4a3b1152b1faba95471` Diff ```patch 1: 1f2d0ffd56 < -: ----------...

reACK 9ef049db5ea30f60d0b72714c42c74e2d816c820

ACK da4377dc2ad0f495ebb97722d6cc2a95850363fa I didn't mind the previous version either, but maybe this preserves more of what's not strictly related to the PR. I think it's an improvement as-is, but I...

Manually recopied https://github.com/bitcoin-core/secp256k1/commit/2f2ccc469540fde6495959cec061e95aab033148 into https://github.com/bitcoin/bitcoin/tree/ff54395de421fa1cbcf80ddbca4d71f0d2a4d12f/src/secp256k1 - seems to be done correctly, no changes detected by git. utACK ff54395de421fa1cbcf80ddbca4d71f0d2a4d12f

> Can you explain what you mean by this I expanded on it in https://github.com/bitcoin/bitcoin/pull/30370#discussion_r1753749012. My understanding is that `ReallocateCache` was introduced to save memory when shrinking the map after...