Results 245 comments of l0rinc
trafficstars

> Could add something like this, but no strong view Done, thanks!

While sigops aren't necessarily difficult to compute, there's a lot of them - and now even more. Please consider the related sigop optimization PR I just pushed: https://github.com/bitcoin/bitcoin/pull/32532

Updated the benchmark to showcase the before/after state better (resembles production code changes), by splitting out the vector copies to the unmetered lambda and having an odd number of elements....

I've rebased the changed and adjusted the benchmark to be more similar to the other production usages in the first commit, rounded to even in the second (optimization) commit, so...

Rebased and added a new commit on top for deduplicating the integer rounding. Ready for review again.

> it could debug-assert that capacity is even ~Added, thanks for the hint~ Edit: had to push a few variants, the fuzzing still seems to fail, so I removed the...

Rebased after https://github.com/bitcoin/bitcoin/pull/33116 - the only conflict was adding `.ToUint256()` to the merkle hashes. Based on the suggestion of @achow101 (since I do agree that it's kinda' leaking abstractions and...

Are you suggesting we revert it in Bitcoin instead?

The new logs can help visualize the flush times and reasons during IBD now - `reindex-chainstate` periodic flushes require https://github.com/bitcoin/bitcoin/pull/32414 Cached coins over time: ![cache_coins_vs_time](https://github.com/user-attachments/assets/a1f21a22-29ed-48b8-8734-a8dc6b282c6d) It's less obvious for used...

> It's not clear to me how the other commits are related to the PR description though They were addressing the review comments I added to the mentioned PR, unifying...