Results 245 comments of l0rinc
trafficstars

Hey @lfbayer, thanks for your quick response! This PR won't fix the underlying cause of `getConnection` not being able to return a live connection, you're right about that. That needs...

If an exception happens in `isConnectionAlive`, even though the catch block will correctly return `false`, it will also [override the last connection failure](https://github.com/brettwooldridge/HikariCP/blob/009a7013cf75b69290abb9bd24b12b66b55a07bf/src/main/java/com/zaxxer/hikari/pool/PoolBase.java#L183), possibly masking the previous one, which could...

Pushed, changed the test to validate that the extra logs are gone.

> I'm still waiting on an explanation of why this change is needed and what problem it solves. Currently exceptions in `isConnectionAlive` override the last connection failure, possibly masking the...

We've bumped into this issue recently, any plans to tackle this in the near future?

Hey Lachlan, we'd like to reuse buffers when sending and receiving [binary messages](https://github.com/eclipse/jetty.project/issues/5048#issuecomment-658613635), i.e. `onWebSocketBinary`, but with a `ByteBuffer` to avoid the GC penalty for many small messages.

Hey Lachlan, thanks for the update. I saw that Jetty was using a `ByteArrayOutputStream` to aggregate the continuation frames to a final buffer in `SimpleBinaryMessage`. What if instead of that,...