l0rinc
l0rinc
> I don't see anything new in these reports compared to [maflcko.github.io/b-c-cov/fuzz.coverage/src/index.html](https://maflcko.github.io/b-c-cov/fuzz.coverage/src/index.html). Thanks for checking! The human readable part is variable now since in Silent Payments it's not just `bc`...
> I don't understand why M1 Macs would have more ops after My understand is that when we've reused the hash as input, it could only run a single instance...
@andrewtoth, this is another tiny addition to the [coincache speedup](https://github.com/bitcoin/bitcoin/pull/28280), your review would be welcome.
That's disappointing, thanks for checking, something's still off with my compiler, it seems. After I finish benching https://github.com/bitcoin/bitcoin/pull/28280#issuecomment-2227314032, I'll try this again on the dedicates server instead. I'm also a...
Now that the other benchmark finished after a few days, I ran this on a `gcc (Debian 12.2.0-14) 12.2.0`. Outdated results After the first run I got a warning of:...
I've removed the `COutPoint_equality` changes and benchmarks (updated the comments to avoid confusion), the `SaltedOutpointHasher` speed gains remain. I'll let you decide if it's worth doing the change or not.
@laanwj This is the optimization that relies on https://github.com/bitcoin/bitcoin/pull/30349, would really appreciate you input on it.
Thanks a lot for the review @sipa. The `SipHash` leaking into the hasher also bothered me a lot (it's also why I closed it a few weeks ago before @laanwj...
@laanwj, @sipa, I've addressed the concerns you've raised, I'd appreciate a re-review here
Rebased to fix a conflict with https://github.com/bitcoin/bitcoin/pull/33116. Also dropped the [benchmarking commit](https://github.com/bitcoin/bitcoin/pull/30442/commits/46f178470bd304edff7e36fe862ba3b23be084ac) to make the change less scary - but kept the patch in the PRs description for anyone interested....