l0rinc

Yes, will do it in the next push!

Thanks @sipa for the review, @achow101 for the comment. I have [pushed](https://github.com/bitcoin/bitcoin/compare/656da514c5a3ee4d376b9b60f57451d3e4b6aec7..d9f3ebfa62b451bac7dfab9a68021f5dc7b5d632) an updated version, extended the optimization from just `SipHashUint256Extra` to cover all `SipHash` operations on `uint256`: * Renamed...

I'm closing it for lack of interest, feel free to cherry-pick changes to other PRs

Thanks @ryanofsky, given that this is in review for more than 1 year, I will address your concerns in a follow-up. rfm?

Thanks for restarting the build @maflcko. @achow101, I can reproduce the same locally, even on Clang 22 using libstdc++ 15. Details ``` [183/612] Building CXX object src/CMakeFiles/bitcoin_node.dir/node/txorphanage.cpp.o 10:44:13 [1552/3036] FAILED:...

I have pushed the [commit](https://github.com/bitcoin/bitcoin/pull/30442/commits/bb57dd5e84108126d41cc03a8dba89c0d9f09a39) on top to not invalidate previous ACKs: ```patch - explicit SaltedOutpointHasher(bool deterministic = false); + SaltedOutpointHasher(bool deterministic = false); ``` I would appreciate a re-review...

> just fixing the commit that introduces the problem Thanks, did that, should be no difference compared to last head, just a fixup of the last commit.

Fixed the remaining linter warnings after the rebase. Details ```patch diff --git a/src/crypto/siphash.h b/src/crypto/siphash.h index 0027a6850e..10d2713257 100644 --- a/src/crypto/siphash.h +++ b/src/crypto/siphash.h @@ -19,15 +19,15 @@ class SipSalt public: explicit SipSalt(uint64_t...

Thanks for the comments, would it make sense to add this to the mac developer notes instead, or should we remove the `-j N` docs, since people are migrating to...

Updated, as I think this can be useful. Once the docs transition to Ninja, we can of course remove these manual steps.