Results 245 comments of l0rinc
trafficstars

@maflcko, I've responded to every single comment within minutes. I just don't appreciate the patronizing style I keep seeing in this repo.

Thanks for the detailed answer @fanquake. > everyone else is busy [...] trying to fight the forest fires So how do we prevent future forest fires while extinguishing current ones?...

@maflcko, would it make sense for me to rebase this or should I just close it at this stage?

moved to a clean slate in https://github.com/bitcoin/bitcoin/pull/30746

@martinus, are you still working on this? If not, I'd like to take over, I've also noticed the same during profiling...

I understand this is still WIP, but checked quickly how much the current impl would speed up the IBD (first 500k blocks with prune, between https://github.com/bitcoin/bitcoin/commit/27a770b34b8f1dbb84760f442edb3e23a0c2420b and https://github.com/bitcoin/bitcoin/commit/2a9c93871cea8c3b1d927a2559ef69ea76c9faf9). Details ```bash...

> Because of that, there is no reason to perform a wiping flush in case the contents of the cache is still useful. I assumed (without diving into the code)...

> The test interface_usdt_utxocache.py fails I haven't reviewed the code in detail yet (since the [build is still failing](https://github.com/bitcoin/bitcoin/pull/30610#pullrequestreview-2277942711)). reproduced build failure ```bash > apt install systemtap-sdt-dev > cmake -B...

Revived in https://github.com/bitcoin/bitcoin/pull/33680, let's continue review there