Results 245 comments of l0rinc
trafficstars

Rebased to fix conflicts with https://github.com/bitcoin/bitcoin/pull/33116

Concept ACK, didn't review it very thoroughly - ping me if you need a full review

Thanks @maflcko, I would actually prefer mentioning nproc (+ alternatives) only once in the docs - will be easier after the cmake PR updates are merged.

> i find it an questionable improvement documentation-wise Yeah, would require more thorough doc updates to clarify that - agree, not worth it

Yeah, I hated how verbose that was. But did a search again and it seems `coreutils` adds `nproc` support, so pushed a PR adding that in the OSx docs: https://github.com/bitcoin/bitcoin/pull/30936/files

Thanks for the review @fanquake and @maflcko - though it was still in draft form because of the unsigned problems. ~I didn't mean the change as a purely stylistic refactoring.~...

@maflcko, you were right, the changes didn't add enough value, I've reverted them. I've kept the tests, since I think they're valuable and unified the style between base 32 and...

@maflcko, which of the listed motivation/review/passing CI doesn't apply here?

Hey @laanwj, thanks for your first review. Please see the commits separately, don't worry, they're not all over the place.