Jacob Walls comments

Results 451 comments of


                                            Jacob Walls

Why does too-many-statements consider statements in nested functions?

This is a good question -- it's either a bug or feature. I think it makes sense to keep the behavior as is, but I'm eager to hear other views,...

Why does too-many-statements consider statements in nested functions?

What do you think of the point about overriding and mock.patch'ing?

False positive `declare-non-slot` on classvar

cc/ @adamtuft, could you lend us your view of this bug report? Thanks!

False negative - assign `list.reverse()` instead of `reversed(list)`

I think the current message makes sense. Happy to add a test case. Or look at a docs suggestion if you think understanding the message can be made simpler?

False negative - assign `list.reverse()` instead of `reversed(list)`

> Suggestion description: Used when an assignment is done on a function call but the inferred function doesn't return anything either implicitly or explicitly. I'm okay with some kind of...

``singleton comparison`` - ==/is true message improvement

Do you think we should use inference? Emit a message for `x is True` just if we infer x only takes boolean values? The "controversy" you point out makes me...

Fixed #36053 -- Corrected DOM structure for FilteredSelectMultiple widget label in admin

Superseded by #20075

Fixed #35667 -- Improved deprecation warning handling by replacing `stacklevel` with `skip_file_prefixes`.

@JaeHyuckSa do you have time to continue with this PR? I think Simon's suggestion for an `emit_warnings` helper is even easier now that main is Python 3.12+.

False Positive - ``assignment-from-none`` raised when function not necessarily returns `None`

The assignment-from-none check needs to consider all possible inferred functions, not merely the first, so it should use `infer_all()`, not `safe_infer()`.

Inconsistent and sometimes incorrect false positive of `no-member` error

Thanks for the analysis. > at least the non-deterministic behavior seems to stem from https://github.com/pylint-dev/pylint/blob/main/pylint/lint/pylinter.py#L667 where the code is trying to convert a set of paths to a list. We...