Bartlomiej Plotka

Results 704 comments of Bartlomiej Plotka
trafficstars

Hey, thanks! That would be helpful if you have time!

No. I did not XD but did not try much... this has to be experimented with

Thanks for starting this discussion. In fact there is minor inconsistency between `NewCounterVec()` and `NewCounter()` (first is returning pointer to struct). Overall, let's try to summarize the problems that you...

Hm, I like the `promauto` in a way that making this part auto-registered and panicking and removing panicking part from `prometheus` seems like a clean and reasonable separation. :+1:

Somehow related: https://github.com/thanos-io/thanos/issues/2430

Do we need protobuf at all in v2? Or it is needed for histograms. We maintain unused protocol https://github.com/prometheus/client_model but with histograms we start to use it more. Still definitely...

Hm, so essentially you want to be able to group collectors better and collect, register and unregister them in one go. I think it's pretty nice characteristics, although at first...

Hmmm what about casting to `Collector` interface in your code for now?

I like it 👍🏽 Again, casting to different interface would also work just fine. Thanks!