Bartlomiej Plotka

Results 704 comments of Bartlomiej Plotka

I have mixed feelings, I agree with both @brancz arguments and @markeijsermans motivation. What about doing.. both? Instead, of adding explicit Method for `EnableHandlingTimeSummary` because users may shoot themselves in...

Yup, something like this. pt., 27 lip 2018, 20:24 użytkownik Mark Eijsermans napisał: > My understanding of the hesitance to directly support summary metrics is > that it is less...

Totally +100 to this. I was thinking about this as well. In fact I think we should care about user error, system error etc. Histograms per grpc code would be...

Here is a plan: https://github.com/grpc-ecosystem/go-grpc-middleware/issues?q=is%3Aissue+is%3Aopen+label%3Av2 Literally, at any point now, we could release v2 officially. We already have release candidates. But I would love to have metrics in first so...

Yes! We are looking for some help as well on that (:

Hi 👋🏽 Sorry for the massive, lag. We consolidating projects and moving to single repo where we have more control and awareness. We are moving this code base longer to...

Not aware of any as well ): Sorry. It does not look like there is any from first glance. Sounds like a cool project to start (:

Hi @jeffwidman, Thanks for this, but I think it would be awesome if we can do this on v2 we plan... and the plan big as we design v2 of...

> In fact, merging to v1 now would make sure it is included in both v1 and v2 stuff, so the fix wouldn't need to later be backported. Not really,...

And we have totally separate implementation so it won't matter much. And yes, if it's a bug we can merge.. But is it?