Bartlomiej Plotka

Results 700 comments of Bartlomiej Plotka
trafficstars

Yes please help! Make sure you to actually do it on `v2` branch which will be released soon. See: https://github.com/grpc-ecosystem/go-grpc-middleware/issues/275 Also I think we might need help in https://github.com/grpc-ecosystem/go-grpc-middleware/issues/277 which...

Well it depends on your method. Depends how big requests you have. (or responses). I would love to have this for certain methods (: On Thu, 21 May 2020 at...

Yea, I am not fan of non-std deps for library, but we have lots of it that are unavoidable, so maybe using dep mngt is actually must-have to ensure users...

@srenatus, since protobuf 1.0.0 did not change any API we use vs our used version, have you try to use https://golang.github.io/dep/docs/Gopkg.toml.html#override in your Gopkg.toml for protobuf to avoid these errors?

I was thinking... would removal of dep and moving to Go modules would help ?

Totally! However, it's mainly for Prometheus part that is now developed here https://github.com/grpc-ecosystem/go-grpc-middleware/tree/v2, I will migrate your issue there if that's fine (:

There is no request yet, but thanks for raising it, definitely help wanted on that. We are planning to add exemplars to HTTP middleware too: https://github.com/prometheus/client_golang/issues/854 so Ideally we can...

I would definitely keep it generic, but would be interesting to mix tracing and metrics libs together (: Can we just add tracing to client_prometheus? 🙈 cc @kakkoyun

Well, the main question is where you get this trace ID from. Then the question is do you want to put trace that is sampled? How do we know that...