Bartlomiej Plotka

Results 700 comments of Bartlomiej Plotka
trafficstars

Got it, we need to fix that caching key part in order to reuse strings 👍🏽

After 3 attempts I found something promising. Looks scary, but it's the only way with the long term to work with vtprotobuf one some streaming plugin. ``` benchstat -col /fmt...

FYI: More realistic benchmarks shows the current (before optimizations) code is actually still faster than text parsers, but allocates more. For all gauges, in a single metric family we we...

Some PRs to review for this: https://cloud-native.slack.com/archives/C01AUBA4PFE/p1739367866185279

Thanks! Sounds like the primary use case is to implement client side filtering (similar to https://github.com/prometheus/client_golang/issues/135 discussion) as well as client side timeout provided via query parameter. Valid use cases,...

Cool, thanks. I think we could try proposing `GathererWithContext`and check if the implementation has it in various places.. and see how it goes. Then perhaps deprecate old one even -...

Yea, agree context would be nice. The selection of metrics or labels to use is something that we ideally have natively, but it's unclear what exactly selection mechanisms would be...

My 2c: I like the current default flow. I started using `lazygit` recently and I generally love the fact the force push is a natural extension of a normal push....

While I agree with what @ArthurSens said, I also think it's ok for client_golang to help with the use case like exposing metrics that process does not control (aka exporter...

Thanks. Let's try to simplify this util code and inline here please. We can make it a proper util abstraction if more Prometheus components will need it.