Bartlomiej Plotka

Results 700 comments of Bartlomiej Plotka
trafficstars

Removing `-u` test too for now as it's misleading most of the time. ``` { name: "Use -u to upgrade thanos package", do: func(t *testing.T, g *goEnv, p *testProject) {...

Thanks, this very good point! Just curious, if we do something like this `//go:generate $COUNTERFEITER -generate` why not just `//go:generate make gen`? (: Would be easier? 🤔 You are right...

Right (: Then: `//go:generate make -C ../ gen` would do 🤗

Alternatively `//go:generate source ../.bingo/variables.env && ${COUNTERFEITER} -generate` if you don't want to use Makefile.

That might work, what's wrong with adding this to your Makefile / script? 🤔 I might think there is no need to add a separate bingo command for such a...

Please do! Thanks (: Kind Regards, Bartek Płotka ***@***.***) On Tue, Jun 15, 2021 at 7:36 PM Jesús García Crespo < ***@***.***> wrote: > That makes sense. I've tried the...

It would need to have multiple vendors for each tools. Possible, worth looking into it then (:

Just to unpack this, do you mean having main go.mod and then bingo controlled `protoc-gen-validate` and ability to sync them. Good point. Normally you need to update both places to...

It won't be super easy, but doable. Open for other suggestions too

cc @Helcaraxan maybe you will know :hugs: (: Maybe I need to double check if old `.sum` is cleared just to make sure Go Modules will work smoother.