Bartlomiej Plotka

Results 700 comments of Bartlomiej Plotka
trafficstars

PR wanted, but this is not v2 blocker though, we an add later.

* Refactor retry code (unncessary elses, readabilty, not mocked tests) * Use interceptor test suite.

Maybe @johanbrandhorst has ideas? I never used gorelease and also we don't build binaries in this project, so what we can leverage? (:

Thanks, @pavolloffay for starting this! 🤗 I am digesting your @jpkrohling response https://github.com/jaegertracing/jaeger/issues/3427#issuecomment-985632588, but I don't get how this is multi-tenant. It only helps with routing to hard tenant elastic...

Good points Juraci, thanks 👍🏽 > How do you ensure the tenant ID is only set at trusted components? By overriding it always on trusted proxy/collector? > What to do...

@gedw99 one thing is to perform DNS resolution less often (cache it), second is making it independently to the request. Also, I think it is all in Golang. If you...

Not in current form. Kedge supports HTTP and gRPC now. However adding another protocol above TCP would be doable I guess (:

Thanks for this! You are welcome to join improbable-eng slack to discuss this (: Link: https://join.slack.com/t/improbable-eng/shared_invite/enQtMzQ1ODcyMzQ5MjM4LWY5ZWZmNGM2ODc5MmViNmQ3ZTA3ZTY3NzQwOTBlMTkzZmIxZTIxODk0OWU3YjZhNWVlNDU3MDlkZGViZjhkMjc and `@bplotka` slack user. From an initial look, it looks simple enough but I...

I think I experienced this in the past too. This is a common problem if someone puts `NOBODY` in the container. Somehow setting UserID in your container when scheduling it...