Bartlomiej Plotka

Yup - it seems flaky. I think because all these tests are based on time (e.g that test case have 1 minute to complete), and Travis being super slow at...

@ppg sorry for the massive delay in review. Let us know If you still want to have this change in new release of `go-grpc-prometheus`.

@ppg can we have your CLA to be signed? Otherwise we cannot merge it ):

Hi 👋🏽 Sorry for the massive, lag. We consolidating projects and moving to single repo where we have more control and awareness. We are moving this code base longer to...

Thanks for this list, definitely package names might be something we should improve, but breaking compatibility is not great (:

Of couse. I believe that there is a lot more value in making one thing better than having 2 separate implementations that does the same thing (:

I would say 3th option - merging (: Adopting your improvements here? Is that an option?

Here you go: https://github.com/grpc-ecosystem/go-grpc-prometheus/tree/draft-v2.0.0

Mixed feelings as well, as cardinality might be the problem for almost no gain. On the other hand IMO knowing latency of error request is useful, but not sure if...

Cool, let's correct docs for now, thank You for finding this! Marking as a docs bug.