Aaron Robertshaw

Results 175 comments of Aaron Robertshaw

I went to pick this issue up but it appears to have been addressed already as of this old commit (D132764-code) that migrated `Follow`/`Following` to `Subscribe`/`Subscribed`. To me personally, it...

Yep, I'll close this. My thinking was that either way it should be quick to clean up.

As noted over in https://github.com/WordPress/gutenberg/issues/63716#issuecomment-2251609539, the adoption of color support for this block probably requires following a similar approach to the [Latest Comments](https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/latest-comments/edit.js?plain=1#L31-L37) block.

> Issue is basically this, It works perfectly fine with global styles. But when block styles are applied, it doesn't override the global styles, Until we save the template and...

> Skipping border style for serverSIderRender wont be enough. This is to be expected. The `skipBlockSupportAttributes` omits the block support values that would be applied as inline styles. Global Styles...

Thanks for adding the inline comments 🚀 LGTM!

> Are there specific reasons for this limitation? Featured images work differently, so they likely need specific handling. My understanding is that this was outside the scope of this PR....

Thanks for the question @huubl 👍 > Maybe I'm missing something, but isn't it just a matter of passing the sizeSlug to the get_the_post_thumbnail() and get_the_post_thumbnail_url() functions in [the index.php...

> Is there any way forward on this effort, or should we close this? @t-hamano and @akasunil are probably best placed to make the call however my read of the...

> I apologize for not noticing this before. Since this PR only add supports of border styles, my attention was solely on those. No apologies needed 🙂 It's easy to...