Aaron Robertshaw

Results 175 comments of Aaron Robertshaw

This PR has been rebased. The video below demos the current state of borders on the Post Featured Image block. There are still several issues with applying borders to the...

Thanks for tweaking the placeholder styles @jasmussen 👍 > What do you think? If you're cool with it, looks like this one needs updated snapshots. It might just be me,...

Thanks for the ping @afercia 👍 > If this CSS property is no longer necessary, we should just remove it. The CSS property is still required as the color panel...

> It would be nice to understand how to replicate this scenario and actually teste the UI with altered order. I'm not sure I can give an explicit step-by-step recipe...

> As a developer, I would expect to see the ContrastChecker being rendered in the exact place where I placed it. I'm not sure this could be guaranteed given SlotFills...

> I will prepare a quick PR to remove the order property but I totally agree this needs to be improved and probably needs design. Before jumping too deep into...

> Anyways, I did some testing and it seems to me the contrast checker within the color group is always rendered last anyways so that I'm not sure the order...

> Is this the relevant commit? https://github.com/WordPress/gutenberg/commit/d5297f2f7ec7045b560ddc9625187a7a01e8fd70 At a glance, I don't think that's related to where a contrast checker is rendered. The Navigation block rendering its own additional contrast...

Understood 👍 This brings the discussion back to my earlier comments around needing design feedback, as displaying the contrast checker as per the example structure order, would break the "item...

Through further exploration, the best compromise option for WP6.6 appears to be: - Keeping the variation styles that are already within the block library so they are still present for...