Aaron Robertshaw
Aaron Robertshaw
The latest plan is to backport all the block support stabilization updates in a single PR. This will include stabilizing border block supports and shared experimental flags such as `__experimentalDefaultControls`...
I've pushed some updates to this PR bringing in the broader stabilization of other block supports e.g. `__experimentalBorder`, `__experimentalSkipSerialization` etc. The [trac ticket](https://core.trac.wordpress.org/ticket/61728) and PR description have been updated with...
Thanks for testing @ramonjd and apologies for the confusion. I should have updated the test instructions on this PR further. > I'm not sure what I should be seeing in...
Quick update: There's an alternate approach being explored as part of https://github.com/WordPress/gutenberg/pull/67729. I'll hold off on committing this PR until that plays out.
It's on the cards that the approach within this PR might be reverted in Gutenberg (see https://github.com/WordPress/gutenberg/pull/68163) and the stabilization of block supports punted for 6.8.
> This PR only updates markup if the type attribute is radio or checkbox. But the type attribute of the v1 fixture is text. I think this is the reason...
> I've split it into [all available types as variations](https://github.com/WordPress/gutenberg/blob/form-input/remove-row-reverse/packages/block-library/src/form-input/variations.js), but should we remove fixtures that aren't affected by the deprecation? Sorry I wasn't more clear with my suggestion @t-hamano....
> Sorry if I didn't understand 😅 It's probably more that I'm not explaining the fixtures I'm proposing very well, without listing every file out individually. > Are there any...
Thanks @t-hamano > 1. Create base fixtures for a generic text input, checkbox, radio, and textarea. These are not fixtures for deprecations, just the current block version. ⬆️ This is...
@t-hamano I've rebased this and pushed some base fixtures for the various form input types. I've also aligned the default fixture with how you combined all the text, email, number,...