Aaron Robertshaw

Results 175 comments of Aaron Robertshaw

> How is this function different than the one in Core? This version allows you to pass an **array** of block types to register a single block style for, instead...

I was a bit slow with my reply 🐢 Hopefully, the extra context helps for posterity as well as explaining the new `style_data` property in the example snippet. _Edit: For...

I've had a go at updating the JS side of the block style registration in https://github.com/WordPress/gutenberg/pull/61029/commits/ba8c6474eb2b50c86e697deca5bb8a607ec60054. It would be great to get a sanity check there and make sure there...

Thanks for the reviews and testing everyone 👍 I'll get this merged and address anything further in follow-ups.

Backport for these changes can be found in: https://github.com/WordPress/wordpress-develop/pull/6609

It's also worth noting that Gutenberg's [reset stylesheet](https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/reset.scss?plain=1#L59) for the iframed editor will have a non-zero specificity as well. Any stylesheet that adds styles for `ul,ol` will break global styles...

@madhusudhand as promised I've pushed a different approach to parsing shadow strings in https://github.com/WordPress/gutenberg/pull/60706/commits/60c40f3e5c5536577dedba7c0ca508d6d51d6317. While that commit gets all 2040 unit tests passing, it was only quickly hacked together and...

> It looks like https://github.com/WordPress/gutenberg/pull/60063 has been approved. Are you facing any blockers? Once https://github.com/WordPress/gutenberg/pull/60063 is merged, this should probably also include the unit test the code change relates to.

There are some proposed changes to specificity in https://github.com/WordPress/gutenberg/pull/61638 and a [general consensus](https://github.com/WordPress/gutenberg/discussions/61810) to proceed with those changes for WP6.6. Given the tight timeline until the 6.6 beta I've put...

Thanks for the ping 👍 > Avoid custom CSS as much as possible. Tool Item component may have a helper attribute so we avoid adding plain HTML. Adding an option...