Aaron Robertshaw
Aaron Robertshaw
cc/ @ramonjd your explorations in https://github.com/WordPress/gutenberg/pull/34156 might mean you'll be interested in reviewing this PR as well.
Thanks for putting this issue together here along with your thoughtful analysis. You make some great points. > Personally, I am 100% convinced that lower-level and higher-level props should not...
> I have created a new issue https://github.com/WordPress/gutenberg/issues/43605 for the problem you mentioned in https://github.com/WordPress/gutenberg/pull/43126#pullrequestreview-1080018363. Thanks for creating the issue and merging this. 👍
This should be pretty close to reviewable, I've run out of time today to test fully but will do that later this week.
> Would it be possible to also apply the styles to the placeholder you find in the template editor when a featured image isn't set, or when no context is...
> Would it be possible to also apply the styles to the placeholder you find in the template editor when a featured image isn't set, or when no context is...
@jameskoster I've updated this PR to apply the border styles to the block's placeholder. It's mostly there except for a small issue around the border radius for the placeholder's SVG....
> could we remove the placeholder border together if one is added via the border control? 🤔 So I'm on the same page, the "placeholder border" to me is the...
Thanks for the enthusiastic reception as well as taking a look at this one @jasmussen, appreciate it 👍 > What do you think? It feels solid to me. This is...
> Let's add this issue to the 6.1 Editor Tasks board and prioritize it This is on my list to rebase and polish up now the placeholder changes are in...