Aaron Robertshaw

Results 175 comments of Aaron Robertshaw

> what do you think ? My thoughts haven't changed. We should maintain backward compatibility whenever possible. > It seems pointless to render an empty element merely for styling purposes....

> I would think it‘s better to put under the Unreleased section I'm not sure if there is a documented official process but this is what https://github.com/WordPress/gutenberg/pull/65905 did. Here's the...

Thanks the `@since` and `@ticket` comments LGTM 👍

> I'd expect an ellipsis button to always be the last button in a set of controls. There's also a separate expectation around where a close button is positioned. I...

> I'm not sure trying to establish which one of these buttons has precedence to be relocated as last would solve the actual issue My comment wasn't intended as a...

> the moving of revisions can trigger way more discussions, as it did with post revisions. > ... What do you say Fair enough, if that was the experience of...

I'd lean towards option 3 as I agree with the arguments against both 1 and 2 so far.

> could this be related to the way it works when using the code editor mode? Good point. I'll give it a bit more of a test. We'll also need...

Nice work implementing the alternate CSS approach @renatho, it's working well for me in my local testing ✨ | Frontend | Editor | |---|---| | | | Given the complexities...

> Does this also happen for you @aaronrobertshaw? From memory, this is due to the way the deprecation attribute objects are created i.e. spreading the previous version's attributes then adding...