wordpress-develop icon indicating copy to clipboard operation
wordpress-develop copied to clipboard

Published 20 hours ago • verified publisher icon WordPress

Reduce specificity of global styles and layout selectors.

Open tellthemachines opened this issue 1 year ago • 4 comments

Trac ticket: https://core.trac.wordpress.org/ticket/61165

Syncs changes from https://github.com/WordPress/gutenberg/pull/60106, https://github.com/WordPress/gutenberg/pull/60228 and https://github.com/WordPress/gutenberg/pull/61340.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

tellthemachines avatar May 08 '24 05:05 tellthemachines

Just realised that changes from #6489 are likely to conflict with these, especially the test string updates, so I might hold off on updating this one until #6489 is committed.

tellthemachines avatar May 08 '24 05:05 tellthemachines

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance, it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

github-actions[bot] avatar May 08 '24 06:05 github-actions[bot]

PHP tests are updated, so marking this ready for review!

tellthemachines avatar May 10 '24 07:05 tellthemachines

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props isabel_brison, aaronrobertshaw.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] avatar May 10 '24 07:05 github-actions[bot]

There are some proposed changes to specificity in https://github.com/WordPress/gutenberg/pull/61638 and a general consensus to proceed with those changes for WP6.6.

Given the tight timeline until the 6.6 beta I've put together a separate draft PR bringing together all the specificity changes from the following PRs:

  • https://github.com/WordPress/gutenberg/pull/60106
  • https://github.com/WordPress/gutenberg/pull/60228
  • https://github.com/WordPress/gutenberg/pull/61340
  • https://github.com/WordPress/gutenberg/pull/61638

Once they settle that could be rolled into this PR or the core ticket updated to point to the alternate backport.

aaronrobertshaw avatar May 26 '24 04:05 aaronrobertshaw

Closing in favour of #6633.

tellthemachines avatar May 28 '24 06:05 tellthemachines