Danny Mösch

Results 396 comments of Danny Mösch
trafficstars

> Really sorry @SimplyDanny, I can’t figure out how to fix the tests. The IntegrationTests seem to pass but I may be running them wrong somehow. I’ve addressed your other...

The remaining fail is a deprecation that has just become active. I'll remove the obsolete rule later and rebase your PR.

> This is firing on collections that aren't Data (specifically `UnsafeBufferPointer`, where converting to Data first would involve a heap copy). ~It's unfortunate that Swift doesn't have a failable conversion...

I still have my concerns with the special handling of custom rules and some improvement ideas in my backlog. Do you mind if I push some changes to your branch...

I managed to avoid explicit type checks at a few places. There are more in other (untouched) code, though, that we should get rid of in the long run. Please...

> > I managed to avoid explicit type checks at a few places. There are more in other (untouched) code, though, that we should get rid of in the long...

> Am I ok to hit merge on this? Oh, I misread this as a statement. Just merged it. 🫣 > Hopefully we'll do better than #4755 🤞 People will...

That's an ambitious plan with 238 existing rules. 😅 But I very much appreciate the effort. This definitely something helpful and can be extended over time with the infrastructure as...

> > That's an ambitious plan with 238 existing rules. 😅 But I very much appreciate the effort. This definitely something helpful and can be extended over time with the...

> I hadn't thought of it like that, but actually I think that is absolutely the best approach. Nothing too prescriptive, and then we can catch anything that goes too...