Reverse Data -> String conversion rule

[samrayner]

trafficstars

This reverses the Data -> String portion of this PR by introducing a new rule, following feedback on the original issue. It leaves the String -> Data portion of the original rule unchanged.

[SimplyDanny]

Please run IntegrationTests locally and fix any violations/failures reported.

[SwiftLintBot]

	215 Warnings
:warning:	This PR introduced a violation in Aerial: /Aerial/Source/Models/API/Forecast.swift:240:38: warning: Optional Data -> String Conversion Violation: Prefer failable String(data:encoding:) initializer when converting Data to String (optional_data_string_conversion)
:warning:	This PR introduced a violation in Aerial: /Aerial/Source/Models/API/GeoCoding.swift:95:38: warning: Optional Data -> String Conversion Violation: Prefer failable String(data:encoding:) initializer when converting Data to String (optional_data_string_conversion)
:warning:	This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OneCall.swift:277:38: warning: Optional Data -> String Conversion Violation: Prefer failable String(data:encoding:) initializer when converting Data to String (optional_data_string_conversion)
:warning:	This PR introduced a violation in Aerial: /Aerial/Source/Models/API/OpenWeather.swift:235:38: warning: Optional Data -> String Conversion Violation: Prefer failable String(data:encoding:) initializer when converting Data to String (optional_data_string_conversion)
:warning:	This PR introduced a violation in Alamofire: /Source/Core/AFError.swift:870:15: warning: Optional Data -> String Conversion Violation: Prefer failable String(data:encoding:) initializer when converting Data to String (optional_data_string_conversion)
:warning:	This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:416:30: warning: Optional Data -> String Conversion Violation: Prefer failable String(data:encoding:) initializer when converting Data to String (optional_data_string_conversion)
:warning:	This PR introduced a violation in Alamofire: /Source/Core/DataStreamRequest.swift:558:9: warning: Optional Data -> String Conversion Violation: Prefer failable String(data:encoding:) initializer when converting Data to String (optional_data_string_conversion)
:warning:	This PR introduced a violation in Alamofire: /Source/Core/Request.swift:1050:28: warning: Optional Data -> String Conversion Violation: Prefer failable String(data:encoding:) initializer when converting Data to String (optional_data_string_conversion)
:warning:	This PR introduced a violation in Alamofire: /Source/Core/Response.swift:441:15: warning: Optional Data -> String Conversion Violation: Prefer failable String(data:encoding:) initializer when converting Data to String (optional_data_string_conversion)
:warning:	This PR introduced a violation in Alamofire: /Tests/ResponseSerializationTests.swift:1368:45: warning: Optional Data -> String Conversion Violation: Prefer failable String(data:encoding:) initializer when converting Data to String (optional_data_string_conversion)
:warning:	This PR introduced a violation in Alamofire: /Tests/ResponseSerializationTests.swift:1380:45: warning: Optional Data -> String Conversion Violation: Prefer failable String(data:encoding:) initializer when converting Data to String (optional_data_string_conversion)
:warning:	This PR introduced a violation in Alamofire: /Tests/TestHelpers.swift:461:9: warning: Optional Data -> String Conversion Violation: Prefer failable String(data:encoding:) initializer when converting Data to String (optional_data_string_conversion)
:warning:	This PR introduced a violation in Brave: /App/BraveWidgets/LockScreenFavoriteWidget.swift:160:59: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Brave: /App/l10n/tools/download-translations-from-transifex.swift:29:22: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Brave: /Sources/Shared/Extensions/StringExtensions.swift:116:27: warning: Optional Data -> String Conversion Violation: Prefer failable String(data:encoding:) initializer when converting Data to String (optional_data_string_conversion)
:warning:	This PR introduced a violation in Brave: /Sources/Shared/SystemUtils.swift:47:20: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Brave: /Tests/BraveNewsTests/OPMLParsingTests.swift:34:30: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Brave: /Tests/BraveNewsTests/OPMLParsingTests.swift:36:30: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Brave: /Tests/SharedTests/HexExtensionsTests.swift:10:20: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Brave: /Tests/SharedTests/HexExtensionsTests.swift:11:20: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in DuckDuckGo: /DuckDuckGo/AutofillDebugViewController.swift:117:96: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in DuckDuckGo: /DuckDuckGo/CrashCollectionOnboardingView.swift:165:35: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/AutoconsentMessageProtocolTests.swift:30:9: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/AutofillLoginListViewModelTests.swift:38:33: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/AutofillLoginListViewModelTests.swift:57:34: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/ContentBlockerProtectionStoreTests.swift:29:9: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/FaviconRequestModifierTests.swift:38:22: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/HashExtensionTest.swift:28:22: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/HashExtensionTest.swift:40:22: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/MockSecureVault.swift:33:27: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/NewTabPageSettingsPersistentStorageTests.swift:38:50: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/Subscription/PrivacyProDataReporterTests.swift:28:22: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/UserAgentTests.swift:150:30: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/UserAgentTests.swift:198:21: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/UserAgentTests.swift:248:26: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/UserAgentTests.swift:304:25: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/UserAgentTests.swift:371:30: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in DuckDuckGo: /DuckDuckGoTests/UserAgentTests.swift:71:22: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in DuckDuckGo: /IntegrationTests/AutoconsentBackgroundTests.swift:31:9: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SharedTests/HexExtensionsTests.swift:10:24: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SharedTests/HexExtensionsTests.swift:11:24: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SharedTests/HexExtensionsTests.swift:15:69: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SharedTests/HexExtensionsTests.swift:16:71: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SharedTests/NetworkUtilsTests.swift:44:31: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Kickstarter: /Kickstarter-iOS/AppDelegateViewModelTests.swift:1076:77: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Kickstarter: /Kickstarter-iOS/AppDelegateViewModelTests.swift:1106:77: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Kickstarter: /Kickstarter-iOS/AppDelegateViewModelTests.swift:1142:77: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Kickstarter: /KsApi/extensions/NSURLSession.swift:145:27: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Kickstarter: /Library/Keychain.swift:112:20: warning: Optional Data -> String Conversion Violation: Prefer failable String(data:encoding:) initializer when converting Data to String (optional_data_string_conversion)
:warning:	This PR introduced a violation in Kickstarter: /Library/ViewModels/SurveyResponseViewModelTests.swift:74:44: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Kickstarter: /Library/ViewModels/SurveyResponseViewModelTests.swift:92:67: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Examples/_shared/GiphyAPI.swift:35:20: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Examples/_shared/GitHubAPI.swift:68:20: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Examples/_shared/GitHubAPI.swift:70:20: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Examples/_shared/GitHubAPI.swift:72:20: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Sources/Moya/Response.swift:175:46: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Sources/Moya/Response.swift:177:52: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointClosureSpec.swift:102:33: warning: Optional Data -> String Conversion Violation: Prefer failable String(data:encoding:) initializer when converting Data to String (optional_data_string_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointClosureSpec.swift:20:89: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointClosureSpec.swift:24:89: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointClosureSpec.swift:37:77: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointClosureSpec.swift:38:77: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointClosureSpec.swift:48:31: warning: Optional Data -> String Conversion Violation: Prefer failable String(data:encoding:) initializer when converting Data to String (optional_data_string_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointClosureSpec.swift:65:77: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointClosureSpec.swift:66:77: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointClosureSpec.swift:78:31: warning: Optional Data -> String Conversion Violation: Prefer failable String(data:encoding:) initializer when converting Data to String (optional_data_string_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:140:28: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:231:28: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:394:113: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:395:126: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:401:113: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:402:126: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:410:146: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:411:159: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:417:146: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:418:159: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:426:122: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:427:135: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:433:122: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:434:135: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:440:130: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:441:143: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:449:155: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:450:168: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:456:155: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:457:168: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:463:155: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:464:168: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:536:89: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:537:102: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:543:89: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:544:102: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:550:89: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:551:102: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:568:70: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:569:83: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:575:70: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/EndpointSpec.swift:576:83: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/MoyaProviderSpec.swift:566:34: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/MoyaProviderSpec.swift:665:34: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/MultiTargetSpec.swift:15:34: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/MultiTargetSpec.swift:61:36: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/NetworkLoggerPluginSpec.swift:133:60: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/NetworkLoggerPluginSpec.swift:158:52: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/NetworkLoggerPluginSpec.swift:181:28: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/NetworkLoggerPluginSpec.swift:204:28: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/NetworkLoggerPluginSpec.swift:57:60: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/NetworkLoggerPluginSpec.swift:68:60: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/TestHelpers.swift:119:20: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/TestHelpers.swift:121:20: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/TestHelpers.swift:123:20: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/TestHelpers.swift:34:20: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in Moya: /Tests/MoyaTests/TestHelpers.swift:36:20: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	This PR introduced a violation in NetNewsWire: /Modules/Account/Sources/Account/URLRequest+Account.swift:26:15: warning: Non-optional String -> Data Conversion Violation: Prefer non-optional Data(_:) initializer when converting String to Data (non_optional_string_data_conversion)
:warning:	Danger found 215 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 114.

	271 Messages
:book:	Linting Aerial with this PR took 0.62s vs 0.63s on main (1% faster)
:book:	Linting Alamofire with this PR took 0.83s vs 0.85s on main (2% faster)
:book:	Linting Brave with this PR took 4.73s vs 4.77s on main (0% faster)
:book:	Linting DuckDuckGo with this PR took 3.13s vs 3.1s on main (0% slower)
:book:	Linting Firefox with this PR took 7.8s vs 7.76s on main (0% slower)
:book:	Linting Kickstarter with this PR took 6.78s vs 6.79s on main (0% faster)
:book:	Linting Moya with this PR took 0.39s vs 0.39s on main (0% slower)
:book:	Linting NetNewsWire with this PR took 1.66s vs 1.7s on main (2% faster)
:book:	Linting Nimble with this PR took 0.53s vs 0.54s on main (1% faster)
:book:	Linting PocketCasts with this PR took 5.92s vs 5.97s on main (0% faster)
:book:	Linting Quick with this PR took 0.33s vs 0.33s on main (0% slower)
:book:	Linting Realm with this PR took 3.2s vs 3.15s on main (1% slower)
:book:	Linting Sourcery with this PR took 1.61s vs 1.59s on main (1% slower)
:book:	Linting Swift with this PR took 2.87s vs 2.87s on main (0% slower)
:book:	Linting VLC with this PR took 0.85s vs 0.86s on main (1% faster)
:book:	Linting Wire with this PR took 11.47s vs 11.5s on main (0% faster)
:book:	Linting WordPress with this PR took 7.47s vs 7.44s on main (0% slower)
:book:	This PR fixed a violation in Aerial: /Aerial/Source/Models/Aerial.swift:249:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Aerial: /Aerial/Source/Models/Aerial.swift:270:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Aerial: /Aerial/Source/Models/Aerial.swift:308:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/TimeMachine.swift:27:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/TimeMachine.swift:54:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Aerial: /Aerial/Source/Models/Cache/TimeMachine.swift:74:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Aerial: /Aerial/Source/Models/Hardware/DisplayDetection.swift:444:33: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Aerial: /Aerial/Source/Models/Hardware/DisplayDetection.swift:486:37: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Aerial: /Aerial/Source/Models/Time/TimeManagement.swift:320:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Alamofire: /Example/Source/DetailViewController.swift:133:39: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /App/BraveWidgets/LockScreenFavoriteWidget.swift:160:59: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /App/l10n/tools/download-translations-from-transifex.swift:29:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Sources/Brave/DeviceCheck/DeviceCheck.swift:357:42: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/New Tab Page/Backgrounds/NewTabPageP3AHelper.swift:110:18: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/Search/BraveSearchManager.swift:147:42: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/Search/BraveSearchManager.swift:225:36: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/User Scripts/FarblingProtectionHelper.swift:90:12: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Sources/Brave/Frontend/Browser/User Scripts/ScriptFactory.swift:138:18: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Sources/Brave/Frontend/Settings/Debug/LocalStateInspectorView.swift:46:20: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Sources/Brave/WebFilters/AdblockRustEngine.swift:69:24: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Sources/Brave/WebFilters/DebouncingService.swift:156:16: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Sources/Brave/WebFilters/DownloadResourceInterface.swift:110:12: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Sources/Brave/WebFilters/ShieldStats/Adblock/AdBlockEngine+Extensions.swift:31:16: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Sources/Brave/WebFilters/ShieldStats/Adblock/AdBlockEngine+Extensions.swift:52:14: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Sources/Brave/WebFilters/ShieldStats/Adblock/AdBlockEngine+Extensions.swift:60:12: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Sources/BraveShared/Extensions/JSONSerializationExtensions.swift:14:19: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Sources/BraveWallet/Keychain.swift:91:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Sources/BraveWallet/Settings/IPFSCustomGatewayView.swift:115:12: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Sources/Growth/URP/UrpService.swift:155:74: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Sources/Growth/URP/UrpService.swift:65:65: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Sources/Shared/Extensions/WKWebViewExtensions.swift:25:26: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Sources/Shared/SystemUtils.swift:47:20: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Tests/BraveNewsTests/OPMLParsingTests.swift:34:30: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Tests/BraveNewsTests/OPMLParsingTests.swift:36:30: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Tests/SharedTests/HexExtensionsTests.swift:10:20: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Brave: /Tests/SharedTests/HexExtensionsTests.swift:11:20: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGo/AutofillDebugViewController.swift:117:96: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGo/AutofillLoginDetailsViewModel.swift:277:67: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGo/BookmarksViewController.swift:900:91: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGo/CrashCollectionOnboardingView.swift:165:35: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGo/CrashCollectionOnboardingViewModel.swift:59:25: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGo/Feedback/VPNMetadataCollector.swift:94:16: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGo/KeychainItemsDebugViewController.swift:36:16: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGo/SaveAutofillLoginManager.swift:66:40: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/AdAttributionFetcherTests.swift:102:24: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/AdAttributionFetcherTests.swift:125:24: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/AdAttributionFetcherTests.swift:52:24: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/AdAttributionFetcherTests.swift:73:24: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/AutoconsentMessageProtocolTests.swift:30:9: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/AutofillLoginListViewModelTests.swift:38:33: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/AutofillLoginListViewModelTests.swift:57:34: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/ContentBlockerProtectionStoreTests.swift:29:9: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/ContentBlockingUpdatingTests.swift:293:37: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/EmbeddedTrackerDataTests.swift:55:24: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/FaviconRequestModifierTests.swift:38:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/HashExtensionTest.swift:28:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/HashExtensionTest.swift:40:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/HtmlTestDataLoader.swift:27:26: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/MockSecureVault.swift:33:27: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/NewTabPageSettingsPersistentStorageTests.swift:38:50: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/Subscription/PrivacyProDataReporterTests.swift:28:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/UserAgentTests.swift:150:30: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/UserAgentTests.swift:198:21: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/UserAgentTests.swift:248:26: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/UserAgentTests.swift:304:25: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/UserAgentTests.swift:371:30: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/UserAgentTests.swift:71:22: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /DuckDuckGoTests/WebViewTestHelper.swift:129:24: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /IntegrationTests/AutoconsentBackgroundTests.swift:31:9: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /LocalPackages/Waitlist/Sources/Waitlist/Storage/WaitlistKeychainStore.swift:79:28: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /PerformanceTests/BookmarksExportPerformanceTests.swift:57:26: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in DuckDuckGo: /PerformanceTests/BookmarksImportPerformanceTests.swift:48:26: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Firefox: /firefox-ios/Client/Frontend/Autofill/Address/AddressListViewModel.swift:331:32: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Firefox: /firefox-ios/Client/Frontend/TabContentsScripts/FormAutofillHelper/FormAutofillHelper.swift:173:37: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Firefox: /firefox-ios/Client/Frontend/TabContentsScripts/FormAutofillHelper/FormAutofillHelper.swift:213:37: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Firefox: /firefox-ios/Client/Frontend/TabContentsScripts/LoginsHelper.swift:336:30: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Firefox: /firefox-ios/Shared/Extensions/Data+Extension.swift:37:16: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Firefox: /firefox-ios/Shared/Extensions/DictionaryExtensions.swift:12:26: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SharedTests/HexExtensionsTests.swift:10:24: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SharedTests/HexExtensionsTests.swift:11:24: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SharedTests/HexExtensionsTests.swift:15:69: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SharedTests/HexExtensionsTests.swift:16:71: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SharedTests/NetworkUtilsTests.swift:44:31: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SyncTests/CryptoTests.swift:49:29: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SyncTests/CryptoTests.swift:53:25: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SyncTests/CryptoTests.swift:57:25: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SyncTests/CryptoTests.swift:61:25: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Firefox: /firefox-ios/firefox-ios-tests/Tests/SyncTests/CryptoTests.swift:65:25: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Kickstarter: /Kickstarter-iOS/AppDelegateViewModelTests.swift:1076:77: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Kickstarter: /Kickstarter-iOS/AppDelegateViewModelTests.swift:1106:77: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Kickstarter: /Kickstarter-iOS/AppDelegateViewModelTests.swift:1142:77: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Kickstarter: /Kickstarter-iOS/Features/LoginTout/Controller/LoginToutViewController.swift:551:17: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Kickstarter: /KsApi/GraphSchema.swift:14:16: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Kickstarter: /KsApi/ServiceTypeTests.swift:184:7: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Kickstarter: /KsApi/extensions/NSURLSession.swift:145:27: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Kickstarter: /KsApi/lib/EncodableType.swift:27:40: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Kickstarter: /Library/Tracking/AttributionTracking.swift:20:12: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Kickstarter: /Library/ViewModels/SurveyResponseViewModelTests.swift:74:44: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Kickstarter: /Library/ViewModels/SurveyResponseViewModelTests.swift:92:67: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Moya: /Dangerfile.swift:126:9: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Moya: /Examples/_shared/GiphyAPI.swift:35:20: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Moya: /Examples/_shared/GitHubAPI.swift:12:16: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Moya: /Examples/_shared/GitHubAPI.swift:12:61: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Moya: /Examples/_shared/GitHubAPI.swift:14:16: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Moya: /Examples/_shared/GitHubAPI.swift:68:20: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Moya: /Examples/_shared/GitHubAPI.swift:70:20: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:book:	This PR fixed a violation in Moya: /Examples/_shared/GitHubAPI.swift:72:20: warning: Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between String and Data (non_optional_string_data_conversion)
:warning:	Danger found 271 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 124.

Generated by :no_entry_sign: Danger

[samrayner]

Really sorry @SimplyDanny, I can’t figure out how to fix the tests. The IntegrationTests seem to pass but I may be running them wrong somehow. I’ve addressed your other comments I think.

[SimplyDanny]

Really sorry @SimplyDanny, I can’t figure out how to fix the tests. The IntegrationTests seem to pass but I may be running them wrong somehow. I’ve addressed your other comments I think.

You need to update default_rule_configurations.yml. IntegrationTests.testDefaultConfigurations checks that it contains all rules with their default options.

[SimplyDanny]

The remaining fail is a deprecation that has just become active. I'll remove the obsolete rule later and rebase your PR.

[samrayner]

Thanks @SimplyDanny! Sorry for the massive delay on fixing up this PR.

[pronebird]

Please roll out an update.

[jrose-signal]

This is firing on collections that aren't Data (specifically UnsafeBufferPointer<UInt8>, where converting to Data first would involve a heap copy). ~~It's unfortunate that Swift doesn't have a failable conversion operation for this, but switching to Data is not automatically the right recommendation either.~~ It needs to use init(bytes:encoding:) instead in that case.

EDIT: Looking at the implementation of init(data:encoding:) in the new swift-foundation, it just immediately turns around and calls init(bytes:encoding:), so that's probably a safe recommendation all the time!

[SimplyDanny]

This is firing on collections that aren't Data (specifically UnsafeBufferPointer<UInt8>, where converting to Data first would involve a heap copy). ~It's unfortunate that Swift doesn't have a failable conversion operation for this, but switching to Data is not automatically the right recommendation either.~ It needs to use init(bytes:encoding:) instead in that case.

EDIT: Looking at the implementation of init(data:encoding:) in the new swift-foundation, it just immediately turns around and calls init(bytes:encoding:), so that's probably a safe recommendation all the time!

With #5794, the rule now suggests String(bytes:encoding:).