Danny Mösch

icon location Stuttgart, Germany icon location You can't argue about taste, but you can about consistency.

Results 346 comments of Danny Mösch
trafficstars

unused_declaration does not catch View only used in PreviewPeovider

Seems to be a good idea to add an option to the rule that makes it treat types only used in previews as unused.

Extraneous whitespace between attribute name and '(';

This should be a pretty simple rule to implement. However, it's probably also not a big deal to fix this only as soon as the Swift 6 compiler complains.

"no_empty_block" causes default functions in protocols to be detected

The thing is that SwiftLint doesn't know that `extension Animal` is an extension of a protocol as it works only on the syntax level. I wonder, though, why you think...

Fix `opening_brace` correction

@swiftty, sorry for being too late with my review here. Parts of your PR had already been fixed by other measures or required more extensive refactoring. Thank you nevertheless for...

Macro exclusion for line_length missing

This seems to be a SourceKit issue, see https://github.com/swiftlang/swift/issues/66666.

Empty Array Initialize

I think this is a matter of taste. Which style is "good" and which is "bad" is subjective. For instance, people might like to omit types wherever possible, so they...