Danny Mösch
Danny Mösch
> String(decoding: data, as: UTF8.self) `String(decoding: data, as: UTF8.self)` may panic at runtime if `data` cannot be represented as UTF-8.
> This just isn't true, `String(decoding:as:)` will insert the replacement character (repair the string) as demonstrated, and as you can see in the [code for the init itself](https://github.com/swiftlang/swift/blob/f858e713ce2bb98a1b2bbfd2d20aa86b3df54cb8/stdlib/public/core/String.swift#L445). How did...
> I don’t believe this rule should be a default one. The behaviour in question is not wrong by definition. It can be a valid and intentional choice depending on...
I admittedly can't make heads or tails of your examples. `addScrubberFeatureTip` isn't called at all and so isn't `observeTip`. `viewWillDisappear` calls or doesn't call `cancelTipObservations`. Where is the connection to...
> I changed the description of my issue to remove personal context from our app and make it more generic. That makes it much clearer. So I think that your...
This issue has been marked as stale because it has not seen any activity in the last 4 months. It is going to be closed soon if it stays inactive.
Hey @aryamansharda, nice to hear from you and even better via a contribution! The implementation looks good to me. Yet, checking the commits that introduced this warning/error in the [Swift...
Yes, you mentioned all the cases we can find in the related Swift compiler diagnostics.
Hey @aryamansharda, anything that's blocking this PR? I'd like to include it into the next major release. Swift 6 is not too far off. To drive this rule useable, we...
Thanks @aryamansharda! I only made the wording more serious to better match the `error` severity and the fact that these violation will be compiler errors in the future. Once the...