Danny Mösch

Results 416 comments of Danny Mösch

Hey @mattmassicotte, I gave an implementation a try in #6290. I'd appreciate your review. Especially the rational might miss an important aspect or could be more extensive, and there might...

This does rather sound like an issue of SwiftUI Previews than an issue of SwiftLint.

You need to be more specific. When it fails to fetch the latest version, what is the error message?

Is this still an issue with the latest version 0.59.1?

Unfortunately, I'm not able to boil this down to a specific commit. It's also hard to reproduce the results in any case. I've done a few tests with the `swift-parser-cli`...

Sorry for the late reply. I've totally missed this thread. I come back to this now that we were about to upgrade to SwiftSyntax 510.0.0, but another performance regression of...

> Do you have some kind of script/commands that I could use to reproduce the measurements? On the PR branch, you can run `./tools/oss-check`. It uses Bazel to build. If...

I checked your branch in [the same PR](https://github.com/realm/SwiftLint/pull/5479) and indeed see an impressive performance improvement of 5% - 25% depending on the linted repository compared to 509. Well done! 🎉

> We deemed the risk of taking this change into a patch release for the 510 series too big ... As a side note: Apart from the performance improvements, all...