Danny Mösch

Results 344 comments of Danny Mösch
trafficstars

The rule suggests to write it like: ```swift extension Data { func jsonDecoded(ofType _: T.Type) throws -> T { try JSONDecoder().decode(T.self, from: self) } } ``` The intention is not...

> @SimplyDanny Added handling of nested if and switch statements. I have a question. I believe that when you initialize a variable in an if or switch expression, the compiler...

Thank you for the contribution! Here are some general remarks: * The rule is supposed to trigger on multiple **statements** on a single line. That is, it is not only...

> and about this pipeline error, I really don't know why!, if you can help me fixing it it would be great. Danger doesn't like merge commits, that's all. You...

> @SimplyDanny I'm trying to rebase on main but I'm afraid of messing everything up actually, as there is conflicts while rebasing and I'm afraid of not including your changes...

> @SimplyDanny the git now is fixed and everything is ready 👍🏼 Commits look okay now. But there's still a few things to consider. Did you read my [other comment](https://github.com/realm/SwiftLint/pull/5990#issuecomment-2640989662)...

@AhmedZaghloul19: Your branch is pretty outdated. Before you work on anything else, I highly recommend to rebase it. Afterwards, please check my other comments.

> > `Issue.captureConsole` > > I've tried to make some tests, but I can't seem to get it work as you suggest. I think it's because it throws the error?...

What about the [`missing_docs`](https://realm.github.io/SwiftLint/missing_docs.html) rule?

I can see that it is fixed even though the comment is supposed to prohibit it. However, the fix that is applied looks correct per se. I can't reproduce the...