zzak
zzak
Sorry for the delay, I've approved but would like to give the chance for another reviewer to merge it.
Found this too: https://github.com/ota42y/openapi_parser/blob/385a9ab60ab349a5972a014f28f2dd10d8b0de98/lib/openapi_parser/schema_validator/string_validator.rb#L58-L61
> Since main now target Rails 8, I could also remove the configuration flag and default to the nonce attribute instead. Even with a major version, we still have to...
This is maybe not a strongly shared opinion, but validations are meant for the user, not developers. What is a user going to do with this error? Would you go...
But can't you already add this validation yourself? ``` validates :item_type, inclusion: { in: %w(Post Comment) } ``` Without the need to add this for your specific use-case.
> make delegated types pass the types option to the polymorphic belongs_to association This and, > Is there an opportunity for this PR to also change the delegated_type implementation to...
CI failures seem unrelated, you might want to rebase just to be sure as I think most of those have been fixed
This is fixed btw. (rails/sdoc#137)
@rubyFeedback Could you explain the use-case? Are you just wanting to run it locally?
I would add a newline gap between the startup and the prompt, otherwise yes!