zzak

> Should I not have edited the CHANGELOG? I’m not sure of the process; was a core maintainer supposed to update that? I really don’t want to keep resolving conflicts…...

It's not uncommon for a committer to rebase the changelog conflict before merging, so I wouldn't worry about constantly trying to keep it up to date while waiting for a...

Carlos gave you his blessing here, but he is really busy now I think: https://github.com/rails/rails/pull/51339#pullrequestreview-1989247117 I will also drop a link in the discord to get it some more eyeballs....

Sorry I noticed there are some relevant errors in CI, can you check? https://buildkite.com/rails/rails/builds/107368#018f9195-b389-43c4-bbb0-cb3982f26f52/1253-1259 ``` activerecord/lib/active_record/core.rb:716:5: W: Lint/DuplicateMethods: Method ActiveRecord::Core#strict_loading_all? is defined at both activerecord/lib/active_record/core.rb:706 and activerecord/lib/active_record/core.rb:716. def strict_loading_all? ^^^^^^^^^^^^^^^^^^^^^^^...

Sorry we haven't had a chance to review this yet, but given there is a repro script I've added the label and that should also give the bot a break...

Thanks for your work on this! Just putting it out there but there is already a linter and w3c validator (not currently run in CI, I believe) on the guides:...

I don't want to make more work for you or reviewers here, apologies for the digression. Let's chat about it after this gets merged.

Just a _very_ quick look at the context around this: * Seems it was added in a81845f26864d076970e706863c766aead432672 * a5b3f372ab30e043d25b25b05e603e6ed33c0ee9 changed the table names and removed the `create_table` Maybe worth looking...

> Will their commit be successful, and should I therefore close this issue? The issue should close automatically once the PR that "fixes #NNNN" is merged.

Unless I'm missing something `ActionDispatch::Testing::TestResponse` is not documented [[ex](https://edgeapi.rubyonrails.org/classes/ActionDispatch/Testing/TestResponse.html)]?