zzak

Results 331 comments of zzak

Still not fixed, so I've opened minitest/minitest#986 with a hack I wrote this morning.

> ActiveStorage::PurgeJob fails if variants are tracked How does the job fail if trackign is enabled?

Thanks for reporting this issue, TIL something new! I think the docs could be improved, to call out these types of gotchas, feel free to submit a PR. Looking at...

Also somewhat related, but I wonder in this case why not wrap the whole thing in a transaction 🤔

I'm not sure how I feel about enabling this for every run, railties already is especially noisy. While I have a PR to fix that, I'm guessing there are cases...

> Is it? Sorry I was confused with --verbose, carry on 😂 > Thing is it's the one for which I want this the most because it's the current CI...

Note: `config.active_storage.web_image_content_types` default will include webp in 7.2 (#50953)

@jamiemccarthy I think we're intentionally saying "Options are passed to the underlying cache implementation." to avoid duplicating effort to document all possible options here.

If `azure-storage-blob` is deprecated, then I think it's worth investigating a replacement or removal.

So one possible (maybe most likely) outcome is that ActiveStorage doesn't ship with an Azure adapter, we deprecate this one, and this behavior is provided by a gem. My reasoning...