zzak

Results 331 comments of zzak

Tests are passing for me now, with this config locally: ```diff diff --git a/actiontext/test/application_system_test_case.rb b/actiontext/test/application_system_test_case.rb index a24f473..dd1d2cb 100644 --- a/actiontext/test/application_system_test_case.rb +++ b/actiontext/test/application_system_test_case.rb @@ -3,7 +3,13 @@ require "test_helper" class ApplicationSystemTestCase...

FYI: buildkite-plugins/docker-compose-buildkite-plugin#419 > images will not be pulled by the plugin (docker should take care of that)

I'm nervous for you having to open a console in prod with write access, this should definitely be avoided at all costs. Not that it isn't supported but there are...

@santib What's left here? I'm happy to help move this along if I can.

My initial thought was partial to `Configurable base controller (current changes)`, but this seems like kind of an anti-pattern. How are other libraries solving this? It seems that the Rails...

Are you storing a unique secret key just for CI?

Thanks for your report! I wonder if this is fixed by #52121

I'm trying to understand this because atm, this feels like a monkey-patch and if there is a valid use-case to change this behavior then perhaps we should introduce a new...

Maybe this helps: * `Rack::MockRequest.env_for` accepts an input option: https://github.com/rack/rack/blob/0b6f760021e01b3031128e81536fc61cef676969/lib/rack/mock_request.rb#L142 * You can also pass in options to `MockRequest#request`: https://github.com/rack/rack/blob/0b6f760021e01b3031128e81536fc61cef676969/lib/rack/mock_request.rb#L66-L67 * We configure the MockRequest in rails here: https://github.com/rails/rails/blob/6045f257fbbff039edb2542c9859488cec0dcaa9/actionpack/lib/action_dispatch/testing/test_request.rb#L17-L21 So...