Gabriel Nordeborn

Results 452 comments of Gabriel Nordeborn

Hi! I don't actively use this anymore, but I'd be happy to accept PRs that fix whatever issues there are. Let me know if you're up for that.

You need to update the test fixtures as well.

@DZakh think you could finish this up?

Could you have a look at the migration and see what the solution might be? What is it doing wrong?

I don't understand. What's the problem here if the migration is _not_ wrong?

Then I would say that the migration isn't correct, or even can't be done, if the APIs are not equivalent. What do you think?

The example is wrong, it does not trigger the warning. Update the example to be: ```rescript // Repro for incorrect "constructor ... is never used" warning with coercions // This...

@jfrolich can you verify whether the test added to this branch gives the expected warning (warns about 1 constructor)?

Great! So @cristianoc it seems the implementation is correct. I think we can move ahead with cleanup.

> > Great! So @cristianoc it seems the implementation is correct. I think we can move ahead with cleanup. > > Any more cases to test? With interfaces? If not,...