Gabriel Nordeborn comments

Results 452 comments of


                                            Gabriel Nordeborn

Completions defined in `editor.autocomplete` don't work on type aliases

Hmm, it's certainly possible, but I wonder if it's clear enough. How would you like it to work for it to be clear/usable enough?

Bindings where `@scope` has same name as module can result in runtime errors

One downside of leveraging `globalThis` is that it doesn't look handwritten. But I guess there's no other good way around this.

Bindings where `@scope` has same name as module can result in runtime errors

Are there any alternative ways around this? Could we detect when this unintended clash happens and only then emit `globalThis`?

RFC: Protected record fields

@cometkim could you point to a few real world examples? Not opposed the functionality, just not something I've encountered often myself.

RFC: Revise `char` primitive

I like it! "Support range patterns for regular integers" especially. But I'm not very read up on these things.

JSX: weird error message when using "children" as prop

What should it say? "Children should be passed as JSX, not a prop"?

No warning on unused but initialised parameters in React components

I believe this is because the JSX v4 emits a switch for the default param case, although not sure. cc @mununki

Promoting rescript-vector to a primitive data structure

I guess having it as a separate installable package makes sense though, right?

PoC: emit code actions from the compiler that the editor tooling can use

Maybe this should incorporate https://github.com/rescript-lang/rescript-compiler/issues/6203 at the same time. This type of functionality opens up for a JSON format anyway.

PoC: emit code actions from the compiler that the editor tooling can use

Superseded by the new work on actions overall.