Gabriel Nordeborn
Gabriel Nordeborn
@cristianoc added a few comments. The changelog text is quite convoluted as well, but I'm not sure I care too much about that.
Let's close it if so, and someone can use the insights here as the base for fixing this later on.
Interesting! What AST does that parse to? I'm sure that error can be improved. It's also a common syntax in TS so we should make it as nice as we...
`bigint` works natively with `@unboxed`: ``` @unboxed type num = | Float(float) | Int(bigint) ```
This message: ``` This untagged variant definition is invalid: At most one case can be a number type (int or float). ``` Means that at most one case can be...
Open to other suggestions of course as well, if you have any.
> I thought it was all straightforward until I saw the locks. Now the question: why did you add locks and how do you know that we don't have deadlocks...
> How about making sure that transitively no mutable global state is accessed? Is that too hard to establish? No that's probably a great idea. I'll give it a shot!...
@cristianoc https://github.com/rescript-lang/rescript/pull/7840/commits/43527087e9794e76b0a85a607ea61ed10bb68173 removes mutexes in favor of domain local caches. No meaningful regression in perf from doing this. But can't help to wonder if there's a better way. We'll of...
Could you add a failing test to utils.js?