Gabriel Nordeborn

Results 452 comments of Gabriel Nordeborn

@jmagaram sorry for missing this, it's great! Would you be fine doing this on the main repo https://github.com/rescript-lang/rescript instead? Core has now been integrated into v12 as the new standard...

Good question. I don't remember exactly how that behavior is defined. Just to clarify - is this still using Core, or is it using the stdlib directly?

I like this proposed solution @glennsl https://github.com/rescript-lang/rescript-core/issues/86#issuecomment-1454708245 If we want to do this then now is the time, as we're shipping the new stdlib in v12 stable.

I like these. @cknitt what do you think? @DZakh could you rebase?

You can add `@taggedTemplate` when it's an external to achieve what you want. What you can't do as of now is have a regular rescript function emitted as a proper...

Just a side note - I don't think we can call these formatter things bugs. It's a formatter behavior that's intentional. You can agree or disagree of course, and there...

You don't need to mark them at all, we can do that as we process it. Just describe what you've found and what you expected, and we can label it...

Observation: The issue seems related to that there are 2 package specs. If you remove the bottom one (the one without `in-source: true`) then it works fine.

Seems to be the exact combination of one with and one without `in-source: true` that's causing the issue. No other combination triggers it for me. EDIT: v12 and Rewatch has...

@benadamstyles could you clarify why you have that combination in `package-specs`?