rescript-compiler icon indicating copy to clipboard operation
rescript-compiler copied to clipboard
verified publisher icon rescript-lang

Fix migration to RegExp.Result.captures

Open DZakh opened this issue 1 month ago • 5 comments

Closing #8029

This was unsettling me, so I decided to create a PR to fix the binding and remove the broken migraiton.

DZakh avatar Nov 24 '25 10:11 DZakh

You need to update the test fixtures as well.

zth avatar Nov 24 '25 10:11 zth

You need to update the test fixtures as well.

plus rebase and CHANGELOG entry (rc.6; will change to final when actually building the release)

cknitt avatar Nov 24 '25 16:11 cknitt

@DZakh think you could finish this up?

zth avatar Dec 03 '25 18:12 zth

Got stuck on a completely outdated local environment. Didn't have time to make it run yet

DZakh avatar Dec 04 '25 09:12 DZakh

Ah, also remembered that there were no way to correctly create an automated migration from value->Re.matches to value

DZakh avatar Dec 04 '25 09:12 DZakh