Gabriel Nordeborn
Gabriel Nordeborn
> One concern: > > Bundling error messages or source information from libraries used in the critical path is not a good idea and should be treated as a development-only...
Yes, that's a great catch and would be very useful. I'm all for it 👍
Maybe we should call it the same as we are calling it in `rescript.json`?
Looks good to me!
> > Maybe it's better to merge #6979 first, then I'll rebase > > Not sure as #6979 is currently blocked by the binary incompatibility issue described in https://github.com/rescript-lang/rescript-compiler/pull/6979/files#r1738735381, so...
> > > Maybe it's better to merge #6979 first, then I'll rebase > > > > > > Not sure as #6979 is currently blocked by the binary incompatibility...
Core will not be optional, as in it will always be available and on by default. This is because one of the big goals with Core is to provide a...
@cometkim IMO you don't need to spend time on getting the error messages right here, we'll have to adjust them anyway as Core is brought in. Yeah, that was a...
Merge! Merge! Merge! 😁
> Looks good. I remember there are some corner case tests in `rescript-core` that would make sense to check. @zth do you remember? Hmmm, I don't immediately recall that. But...