rescript-core icon indicating copy to clipboard operation
rescript-core copied to clipboard
verified publisher icon rescript-association

Add RegExp.flags function with tests

Open jmagaram opened this issue 7 months ago • 2 comments

This PR adds the flags getter function to the RegExp module, which returns a string consisting of the flags of a given regular expression object.

Changes:

  • Added flags external binding to Core__RegExp.res
  • Added documentation with examples to Core__RegExp.resi
  • Created new RegExpTests.res file with tests for the flags function
  • Added RegExpTests to TestSuite.res

All tests are passing.

https://github.com/rescript-lang/rescript-core/issues/253

jmagaram avatar May 05 '25 03:05 jmagaram

@jmagaram sorry for missing this, it's great! Would you be fine doing this on the main repo https://github.com/rescript-lang/rescript instead? Core has now been integrated into v12 as the new standard library, so all efforts go in there now.

I realize we should make that much more obvious as well when you look at the repo, sorry about that.

zth avatar May 09 '25 12:05 zth

https://github.com/rescript-lang/rescript/pull/7461

jmagaram avatar May 10 '25 23:05 jmagaram