Joshua Barretto comments

Results 755 comments of


                                            Joshua Barretto

Implement Debug for async futures/streams

Thanks, this is ideal. It seems there is a conflict though, but this should be a trivial change.

feature request: control context lines around labels

Configurable context is something I plan to add to ariadne's rewrite (you can see the `ariadne2` branch for current progress, if you're curious).

feat: Use RPITIT instead of Box<dyn ...>

Thanks for the PR. Sorry, it got lost in my notifications. I think this is a positive change, although I'm surprised it's been stable for so long already: I'm used...

fix inconsistent naming and functions provided

Looks like it needs a `cargo fmt`.

Pratt parser only implemented for tuples A..Z

Hmm, you're right that this is a bit of an annoyance. `choice` supports > 26 because it allows for nesting, but of course the same does not apply for `pratt`....

Pratt parser only implemented for tuples A..Z

An alternative solution might be to allow `pratt` to work with arrays/vectors as `choice` does. This would require boxing the operators, but that's not necessarily a problem.

Pratt parser only implemented for tuples A..Z

It would make it a bit harder for it to optimise most likely, yes. The compiler might still be able to perform devirtualisation if it's smart enough though.

Pratt parser only implemented for tuples A..Z

I made an attempt to implement this a while back but ran into issues. I might attempt it again later.

Fix URLs in README (`master` -> `main`)

Thanks!

Add a `spanned` method for automatically wrapping the parser result in a `Span`

I've considered this a few times, but in practice it's far from a convention to represent the two as a tuple: folks often create a `struct Spanned(T, Span);` type that...