Joshua Barretto

Results 755 comments of Joshua Barretto

That's a reasonable compromise for now, thanks. Looks like it just needs a `cargo fmt` :)

FYI, it looks like you might have accidentally piped some `git log` output into a file named [`et --soft HEAD~1`](https://github.com/zesterer/ariadne/pull/159/files#diff-5ec957c1cc0b7ea2ea5cf258a68f06ff487f67aabb939b8b916a6fefbb8e9433) and committed it. I think I'm less convinced by the...

I was asleep. It looks like `et --soft HEAD~1` is still present, so that needs removing before merge (ideally by amending the commit). I think that's all then.

I've not looked too closely at the specific requirements of the traits, but I can't imagine anything specific about Flume's implementation that would disallow their implementation, especially for the sync...