Joshua Barretto

Results 755 comments of Joshua Barretto

Hello. `then_with` was removed for performance/introspection reasons (it's effectively a 'black box' to chumsky, and in the future we're likely to start doing more and more up-front optimisation work on...

I think the problem is your use of the explicit parameters here: ```rs let open = just::

I assume no change in the error message? The next step is to start removing things until it works. `close`, for example, is unnecessary for the parser to compile. The...

So, interestingly, there's nothing fundamental that prevents `select!` supporting regular inputs. I'm tempted to just relax the bounds required, but that would require an explicit token clone - which should...

Hmm, true! I've just pushed a commit to `main` that relaxes the bound, perhaps this works for you?

So this actually existed in 0.9: `Error` [had a dedicated method](https://github.com/zesterer/chumsky/blob/5101cc86a8568a6d33743145e5e8bd0b194332b8/src/error.rs#L109-L118) for unclosed delimiters and the `nested_delimiters` recovery strategy would [make use of it](https://github.com/zesterer/chumsky/blob/legacy/src/recovery.rs#L231-L237). We could do exactly the same...

I like the idea of moving this to a label, that seems very forward-thinking. The thing that makes this a bit more complex is that just pinning it to `delimited_by`...

This should be solvable simply by using the output. Regardless, parser state doesn't generally exist for the purpose of performing arbitrary mutation - parsers are supposed to be pure-in-principle, so...

I'm happy to accept a PR for a name change since this is intended as a semi-internal trait. That said, I think the underlying problem here is with your IDE....

Thanks! Edit: It seems like this PR is failing, perhaps it's better to implement `Debug` manually? Avoiding revealing internal implementation details would also be good, I think.